Use macro for exception raising#3485
Draft
MightyJosip wants to merge 10 commits intopygame-community:mainfrom
Draft
Use macro for exception raising#3485MightyJosip wants to merge 10 commits intopygame-community:mainfrom
MightyJosip wants to merge 10 commits intopygame-community:mainfrom
Conversation
ankith26
reviewed
Jun 9, 2025
Member
ankith26
left a comment
ankith26
left a comment
There was a problem hiding this comment.
Overall I really like this idea but I think we should only introduce the macro for the return -1 case. The current raise could remain RAISE as it is a better shorthand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2371 we added support for one liner for setting exception and returning the value from the functions. If the return value is NULL, we have the same support for 10+ years. In this PR I replaced all the calls to PyErr_SetString (and returning the value) with those macros. There is still work to be done with PyErr_Format, but that would make this commit too big, so I will do that in the future.